fixes force atlas to allow string as vertex names #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed dependence on mtx files in test.
acostadon
added
the
improvement
BradReesWork
approved these changes
Sep 28, 2023
nv-rliu
approved these changes
Sep 28, 2023
|
rerun tests |
rlratzel
requested changes
Sep 28, 2023
|
/merge |
rlratzel
previously requested changes
Sep 29, 2023
| # relocated in the third-party group once this gets fixed. | ||
|
|
||
| # FIXME Removed the multi column positional due to it being non-deterministic | ||
| # need to replace this coverage. Issue 3890 in cuGraph repo was created. |
There was a problem hiding this comment.
I can't find issue 3890 in the cugraph repo. Are you sure this is the right number?
There was a problem hiding this comment.
I'm assuming you meant issue 3900 ?
|
#3900
I messed up
From: Rick Ratzel ***@***.***>
Sent: Friday, September 29, 2023 3:03 PM
To: rapidsai/cugraph ***@***.***>
Cc: Don Acosta ***@***.***>; Assign ***@***.***>
Subject: Re: [rapidsai/cugraph] fixes force atlas to allow string as vertex names (PR #3891)
@rlratzel requested changes on this pull request.
________________________________
In python/cugraph/cugraph/tests/layout/test_force_atlas2.py<#3891 (comment)>:
@@ -27,15 +27,13 @@
dining_prefs,
)
-# Temporarily suppress warnings till networkX fixes deprecation warnings
-# (Using or importing the ABCs from 'collections' instead of from
-# 'collections.abc' is deprecated, and in 3.8 it will stop working) for
-# python 3.7. Also, these import fa2 and import networkx need to be
-# relocated in the third-party group once this gets fixed.
-
+# FIXME Removed the multi column positional due to it being non-deterministic
+# need to replace this coverage. Issue 3890 in cuGraph repo was created.
I can't find issue 3890 in the cugraph repo. Are you sure this is the right number?
—
Reply to this email directly, view it on GitHub<#3891 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXIDBAC5J75SZLBGS7UWGP3X44LNPANCNFSM6AAAAAA5J4QOFI>.
You are receiving this because you were assigned.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes force atlas to allow string as vertex names and removes need for mtx formated datasets.
resolves #3610