-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate renumbering and compression to cugraph-dgl
to accelerate MFG creation
#3887
Merged
rapids-bot
merged 108 commits into
rapidsai:branch-23.10
from
tingyu66:dgl-mfg-integration
Oct 3, 2023
+250
−28
Merged
Changes from 104 commits
Commits
Show all changes
108 commits
Select commit
Hold shift + click to select a range
f0e9f1f
move sampling relatd functions in graph_functions.hpp to sampling_fun…
seunghwak 3b1fd23
draft sampling post processing function APIs
seunghwak 67f4d7b
API updates
seunghwak 8f521d2
API updates
seunghwak da3da9b
deprecate the existing renumber_sampeld_edgelist function
seunghwak 0b87ee1
combine renumber & compression/sorting functions
seunghwak 9b5950b
minor documentation updates
seunghwak 5fbb177
mionr documentation updates
seunghwak b9611ab
deprecate the existing sampling output renumber function
seunghwak c3ee02b
initial implementation of sampling post processing
seunghwak 04c9105
cuda::std::atomic=>cuda::atomic
seunghwak bdc840c
update API documentation
seunghwak 8c304b3
add additional input testing
seunghwak b16a071
replace testing for sampling output post processing
seunghwak 09a38d7
cosmetic updates
seunghwak 82ad8e4
bug fixes
seunghwak d99b512
Merge branch 'fea_mfg' of https://github.com/seunghwak/cugraph into c…
alexbarghi-nv c15d580
the c api
alexbarghi-nv 9135629
fix compile errors
alexbarghi-nv dfd1cb7
reformat
alexbarghi-nv 6dfd4fe
rename test file from .cu to .cpp
seunghwak 7d5821f
bug fixes
seunghwak 58189ed
add fill wrapper
seunghwak 39db98a
undo adding fill wrapper
seunghwak 98c8e0a
sampling test from .cpp to .cu
seunghwak c151f95
fix a typo
seunghwak fc5a4f0
Merge branch 'branch-23.10' of github.com:rapidsai/cugraph into fea_mfg
seunghwak 094aaf9
do not return valid nzd vertices if doubly_compress is false
seunghwak cf57a6d
bug fix
seunghwak 2b48b7e
test code
seunghwak 79acc8e
Merge branch 'branch-23.10' of github.com:rapidsai/cugraph into fea_mfg
seunghwak 0481bfb
Merge branch 'branch-23.10' into cugraph-sample-convert
alexbarghi-nv 2af9333
Merge branch 'fea_mfg' of https://github.com/seunghwak/cugraph into c…
alexbarghi-nv 23cd2c2
bug fix
seunghwak 6eaf67e
update documentation
seunghwak 4dc0a92
fix c api issues
alexbarghi-nv 2947b33
Merge branch 'branch-23.10' of https://github.com/rapidsai/cugraph in…
alexbarghi-nv 0a2b2b7
C API fixes, Python/PLC API work
alexbarghi-nv db35940
adjust hop offsets when there is a jump in major vertex IDs between hops
seunghwak b8b72be
add sort only function
seunghwak 38dd11e
Merge branch 'branch-23.10' of github.com:rapidsai/cugraph into fea_mfg
seunghwak c86ceac
various improvements
alexbarghi-nv 37a37bf
Merge branch 'fea_mfg' of https://github.com/seunghwak/cugraph into c…
alexbarghi-nv 002fe93
fix merge conflict
alexbarghi-nv 5051dfc
fix bad merge
alexbarghi-nv 6cdf92b
asdf
alexbarghi-nv 6682cb4
clarifying comments
alexbarghi-nv 0d12a28
t
alexbarghi-nv f5733f2
latest code
alexbarghi-nv 52e2f57
bug fix
seunghwak befeb25
Merge branch 'branch-23.10' of github.com:rapidsai/cugraph into bug_o…
seunghwak 8781612
additional bug fix
seunghwak f92b5f5
add additional checking to detect the previously neglected bugs
seunghwak 2bd93d9
Merge branch 'bug_offsets' of https://github.com/seunghwak/cugraph in…
alexbarghi-nv 3195298
wrap up sg API
alexbarghi-nv 74195cb
test fix, cleanup
alexbarghi-nv 374b103
refactor code into new shared utility
alexbarghi-nv bd625e3
get mg api working
alexbarghi-nv b2a4ed1
add offset mg test
alexbarghi-nv 9686ae3
fix typos
tingyu66 9fb7438
fix renumber map issue in C++
alexbarghi-nv 2ade9c3
empty commit to test signing
tingyu66 c770a17
verify new compression formats for sg
alexbarghi-nv b569563
complete csr/csc tests for both sg/mg
alexbarghi-nv ab2a185
get the bulk sampler working again
alexbarghi-nv 89a1b33
remove unwanted file
alexbarghi-nv a9d46ef
fix wrong dataframe issue
alexbarghi-nv 17e9013
update sg bulk sampler tests
alexbarghi-nv c5543b2
fix mg bulk sampler tests
alexbarghi-nv 16e83bc
write draft of csr bulk sampler
alexbarghi-nv 1e7098d
overhaul the writer methods
alexbarghi-nv ae94c35
remove unused method
alexbarghi-nv 7beba4b
style
alexbarghi-nv 16ed5ef
Merge branch 'branch-23.10' of https://github.com/rapidsai/cugraph in…
alexbarghi-nv 79e3cef
remove notebook
alexbarghi-nv fd5cceb
add clarifying comment to c++
alexbarghi-nv a47691d
add future warnings
alexbarghi-nv 195d063
cleanup
alexbarghi-nv 0af1750
remove print statements
alexbarghi-nv d65632c
fix c api bug
alexbarghi-nv 247d8d2
revert dataloader change
alexbarghi-nv 72bebc2
fix empty df bug
alexbarghi-nv 4d51751
style
alexbarghi-nv 9dfa3fa
io
alexbarghi-nv 10c8c1f
fix test failures, remove c++ compression enum
alexbarghi-nv 08cf3e1
remove removed api from mg tests
alexbarghi-nv 358875f
formats
tingyu66 1b0cc1f
Merge branch 'cugraph-sample-convert' into dgl-mfg-integration
tingyu66 eb3aadc
fix wrong index + off by 1 error, add check in test
alexbarghi-nv a124964
Merge branch 'branch-23.10' into cugraph-sample-convert
alexbarghi-nv 6990c23
add annotations
alexbarghi-nv 920bed7
docstring correction
alexbarghi-nv f8df56f
remove empty batch check
alexbarghi-nv 5238c81
Merge branch 'cugraph-sample-convert' into dgl-mfg-integration
tingyu66 ef2ec5b
fix capi sg test
alexbarghi-nv 8e22ab9
disable broken tests, they are too expensive to fix and redundant
alexbarghi-nv 13bdd43
Merge branch 'cugraph-sample-convert' of https://github.com/alexbargh…
alexbarghi-nv 77a5ba3
Merge branch 'cugraph-sample-convert' into dgl-mfg-integration
tingyu66 757f385
process raw csc df output
tingyu66 22217dc
cast to tensors, create list for minibatches
tingyu66 7f838ae
infer n_hops, n_batches from df
tingyu66 6531e14
enable csc loader
tingyu66 3a6b6b9
docstring
tingyu66 564ddb4
Merge branch 'branch-23.10' into dgl-mfg-integration
tingyu66 9e73617
add test using karate dataset
tingyu66 e9c8bbb
improve slicing
tingyu66 3620321
Merge branch 'branch-23.10' into dgl-mfg-integration
tingyu66 45f93f2
update seeds_per_call default value
tingyu66 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tingyu66 , Can we also change
seeds_per_call
to100_000
to make a better default based on your testing ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change it to the default value of BulkSampler:
200_000
? After our call the other day, I tested a wide range ofseeds_per_call
values and none of the runs threw a OOM error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, if it just works we can probably set the default to None and let upstream handle it ? What do you think, any default which is reasonable and just works is fine by me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the value to
200_000
in 45f93f2 to align with BulkSampler. Did not set to None to avoid the extra step of handling None case.