Enable weights for MG similarity algorithms #3879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
naimnv
reviewed
Sep 26, 2023
Comment on lines
76
to
+79
| input_data_path = input_combo["graph_file"] | ||
| directed = input_combo["directed"] | ||
| has_vertex_pair = input_combo["has_vertex_pair"] | ||
| G = utils.generate_cugraph_graph_from_file(input_data_path, directed=directed) | ||
| is_weighted = input_combo["is_weighted"] |
There was a problem hiding this comment.
I wonder, wouldn't it be cleaner to have these column names as global variable declared at the beginning of the files?
naimnv
added
improvement
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to #3828 which enabled weighted for the python SG similarity algorithms.
This PR also updates the tests, docstrings and remove experimental calls