Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix torch seed in cugraph-dgl and -pyg tests for conv layers #3869

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

tingyu66
Copy link
Member

Fixes https://github.com/rapidsai/graph_dl/issues/325

Recently, a few CI runs (ex. 1, 2) failed when comparing results from cugraph-ops-based conv layers against results from upstream frameworks. The tests pass most of the time, but occasionally fail due to a combination of using a strict tolerance and bad numerics (floating point error). This PR fixes the seed used for generating random feature tensors so that CI behaves consistently across different runs.

@tingyu66 tingyu66 requested a review from a team as a code owner September 21, 2023 17:00
@tingyu66 tingyu66 added bug Something isn't working non-breaking Non-breaking change labels Sep 21, 2023
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit f53bb56 into rapidsai:branch-23.10 Sep 22, 2023
54 checks passed
@tingyu66 tingyu66 deleted the fix-torch-seed branch September 22, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants