Skip to content

Commit

Permalink
Replace local copyright check with pre-commit-hooks verify-copyright (#…
Browse files Browse the repository at this point in the history
…4130)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Brad Rees (https://github.com/BradReesWork)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)
  - Brad Rees (https://github.com/BradReesWork)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #4130
  • Loading branch information
KyleFromNVIDIA authored Mar 11, 2024
1 parent c4a531d commit 69aef7f
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 279 deletions.
20 changes: 12 additions & 8 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,20 @@ repos:
)
types_or: [c, c++, cuda]
args: ["-fallback-style=none", "-style=file", "-i"]
- repo: local
hooks:
- id: copyright-check
name: copyright-check
entry: python ./ci/checks/copyright.py --git-modified-only --update-current-year
language: python
pass_filenames: false
additional_dependencies: [gitpython]
- repo: https://github.com/rapidsai/dependency-file-generator
rev: v1.8.0
hooks:
- id: rapids-dependency-file-generator
args: ["--clean"]
- repo: https://github.com/rapidsai/pre-commit-hooks
rev: v0.0.1
hooks:
- id: verify-copyright
files: |
(?x)
[.](cmake|cpp|cu|cuh|h|hpp|sh|pxd|py|pyx)$|
CMakeLists[.]txt$|
CMakeLists_standalone[.]txt$|
[.]flake8[.]cython$|
meta[.]yaml$|
setup[.]cfg$
271 changes: 0 additions & 271 deletions ci/checks/copyright.py

This file was deleted.

0 comments on commit 69aef7f

Please sign in to comment.