add fixme

rapidsai · Mar 1, 2024 · 5e95bb4 · 5e95bb4
1 parent e824eb3
commit 5e95bb4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/cpp/src/community/k_truss_impl.cuh b/cpp/src/community/k_truss_impl.cuh
@@ -48,7 +48,7 @@ namespace cugraph {
 
 template <typename vertex_t, typename edge_t, typename EdgeIterator>
 struct unroll_edge {
-  raft::device_span<edge_t> num_triangles{};
+  raft::device_span<edge_t> num_triangles{};  // FIXME: invalid type for unsigned integers
   EdgeIterator edge_unrolled{};
   EdgeIterator transposed_edge_first{};
   EdgeIterator edge_last{};

diff --git a/cpp/src/structure/edge_triangle_count_impl.cuh b/cpp/src/structure/edge_triangle_count_impl.cuh
@@ -112,6 +112,7 @@ std::enable_if_t<!multi_gpu, rmm::device_uvector<edge_t>> edge_triangle_count_im
                              std::array<bool, 2>{true, true},
                              false /*FIXME: pass 'do_expensive_check' as argument*/);
 
+  // FIXME: invalid type for unsigned integers.
   rmm::device_uvector<edge_t> num_triangles(edgelist_srcs.size(), handle.get_stream());
 
   // Update the number of triangles of each (p, q) edges by looking at their intersection
@@ -149,8 +150,6 @@ std::enable_if_t<!multi_gpu, rmm::device_uvector<edge_t>> edge_triangle_count_im
       raft::device_span<edge_t>(num_triangles.data(), num_triangles.size()),
       edge_first});
 
-  // rmm::device_uvector<vertex_t> num_triangles(
-  //   2, handle.get_stream());
   return num_triangles;
 }