Skip to content

Commit

Permalink
Fix CCCL 2.7.0-rc2 compile issue by removing reference from values. (#…
Browse files Browse the repository at this point in the history
…4799)

We are planning to migrate to CCCL 2.7.0 in RAPIDS 25.02. I found a compilation error in `libcugraph_etl` that is fixed by removing a reference `&` from a device comparator, and passing the parameters by value instead.

This is a pretty small fix but I expect we will want to build 24.12 with newer CCCL versions for DLFW releases. To avoid needing a backport for DLFW, I am targeting 24.12 with this change. I can retarget to 25.02 if desired.

This is extracted from #4743, but that PR shouldn't be merged (it includes testing changes that are not intended for merge).

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #4799
  • Loading branch information
bdice authored Dec 4, 2024
1 parent 50a11b1 commit 18505a8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp/libcugraph_etl/src/renumbering.cu
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,7 @@ __global__ static void select_unrenumber_string(str_hash_value* idx_to_col_row,
}

struct struct_sort_descending {
__host__ __device__ bool operator()(str_hash_value& a, str_hash_value& b)
__host__ __device__ bool operator()(str_hash_value a, str_hash_value b)
{
return (a.count_ > b.count_);
}
Expand Down

0 comments on commit 18505a8

Please sign in to comment.