Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nightly docs workflow dependencies #97

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix nightly docs workflow dependencies #97

merged 1 commit into from
Dec 17, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Dec 17, 2024 •
edited
Loading

The branch build triggered by merging #96 failed immediately.

The workflow is not valid. .github/workflows/build.yaml (Line: 47, Col: 12): Job 'docs-build' depends on unknown job 'conda-cpp-build'.

(build link)

This fixes that.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 17, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb
Copy link
Member Author

/ok to test

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 17, 2024
@jameslamb jameslamb requested a review from acostadon December 17, 2024 19:13
@jameslamb jameslamb marked this pull request as ready for review December 17, 2024 19:13
@jameslamb jameslamb requested a review from a team as a code owner December 17, 2024 19:13
@jameslamb jameslamb requested a review from msarahan December 17, 2024 19:13
@jameslamb jameslamb mentioned this pull request Dec 17, 2024
Closed
acostadon
acostadon approved these changes Dec 17, 2024
View reviewed changes
Copy link

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit e641496 into rapidsai:branch-25.02 Dec 17, 2024
83 checks passed
@jameslamb jameslamb deleted the fix/nightly-docs-build branch December 17, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostadon acostadon acostadon approved these changes

@bdice bdice bdice approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameslamb @bdice @acostadon