Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cudf._lib.utils in favor of python APIs #17625

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #17317

Dependent on #17582

Did a search across RAPIDS and Morpheus and didn't find usage of these methods.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Sorry, something went wrong.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 19, 2024
@mroeschke mroeschke self-assigned this Dec 19, 2024
Copy link

copy-pr-bot bot commented Dec 19, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the CMake CMake build issue label Dec 19, 2024
@mroeschke mroeschke marked this pull request as ready for review December 19, 2024 19:37
@mroeschke mroeschke requested a review from a team as a code owner December 19, 2024 19:37
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We don't have to implement them now, but I suspect that we will be able to capture more useful helper functions for these translations over time. We've definitely proliferated too many of them in the past, though, so for now I'm good with inlining code to see what patterns emerge rather than defining helpers prematurely.

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 69d62cb into rapidsai:branch-25.02 Dec 20, 2024
106 checks passed
@mroeschke mroeschke deleted the cudf/_lib/utils branch December 20, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants