Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more pylibcudf.types instead of cudf._lib.types #17619

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #17317

Primary change is to use pylibcudf.TypeId instead of an ad-hoc one defined in cudf._lib.types. Additionally uses pylibcudf more consistently and inlines/removes some seldom uses/dead code

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 18, 2024
@mroeschke mroeschke self-assigned this Dec 18, 2024
@mroeschke mroeschke requested a review from a team as a code owner December 18, 2024 03:49
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b06f510 into rapidsai:branch-25.02 Dec 20, 2024
106 checks passed
@mroeschke mroeschke deleted the cudf/_lib/types/pt1 branch December 20, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants