Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cudf._lib.copying to cudf.core._internals #17548

Open
wants to merge 10 commits into
base: branch-25.02
Choose a base branch
from
Open

Move cudf._lib.copying to cudf.core._internals #17548

wants to merge 10 commits into from

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Dec 7, 2024 •
edited
Loading

Description

Contributes to #17317

Also I found that PackedColumns was not being use anywhere. It appears it was added back in #8153 for dask_cudf but I cannot see it being used there anymore

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 7, 2024
@mroeschke mroeschke self-assigned this Dec 7, 2024
@mroeschke mroeschke requested a review from a team as a code owner December 7, 2024 01:43
@github-actions github-actions bot added the CMake CMake build issue label Dec 7, 2024
vyasr
vyasr reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the main benefit of this PR that we go from Cython (copying.pyx) to Python (internals/copying.py)? Otherwise it's just a code move right?

@mroeschke
Copy link
Contributor Author

Is the main benefit of this PR that we go from Cython (copying.pyx) to Python (internals/copying.py)? Otherwise it's just a code move right?

Yup, exactly. Some of the methods in copying.pyx were only called once (since a parent, Python API was the common access point to it), so I also in-lined those too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr left review comments

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@mroeschke mroeschke

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr