Propagate failures in pandas integration tests #17489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
Matt711
approved these changes
Dec 3, 2024
9 tasks
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Matt711
force-pushed
the
wence/fix/pandas-integration-propagate-failure
branch
from
96bc1d1 to
f54c1a5
Compare
Matt711
added a commit
to Matt711/cudf
that referenced
this pull request
Dec 3, 2024
3 tasks
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
…#17521) This PR ensures that the integration tests fail in any one of the test modules fails. It also skips of xfails any tests that are not currently passing. Finally, it fixes one incorrect use of `rng.random`. Some of the change were originally made in #17489 Authors: - Matthew Murray (https://github.com/Matt711) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #17521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to not remembering exitcodes for the individual integration test failures, we would only report a failure in CI if the last integration test failed.
Fix that, and fix one incorrect use of rng.random.
Checklist