Move cudf._lib.sort to cudf.core._internals #17488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
…to cudf/_lib/sort
Matt711
approved these changes
Dec 12, 2024
Comment on lines
56
to
59
| column_order = [plc.types.Order.DESCENDING] * len(source_columns) | ||
| for idx, val in enumerate(ascending): | ||
| if val: | ||
| column_order[idx] = plc.types.Order.ASCENDING |
There was a problem hiding this comment.
Suggested change
| column_order = [plc.types.Order.DESCENDING] * len(source_columns) | |
| for idx, val in enumerate(ascending): | |
| if val: | |
| column_order[idx] = plc.types.Order.ASCENDING | |
| column_order = [ | |
| plc.types.Order.ASCENDING if val else plc.types.Order.DESCENDING | |
| ] |
There was a problem hiding this comment.
Good idea. (Incorporated the missing for loop here though)
Comment on lines
69
to
72
| null_precedence = [plc.types.NullOrder.AFTER] * len(source_columns) | ||
| for idx, val in enumerate(null_position): | ||
| if val: | ||
| null_precedence[idx] = plc.types.NullOrder.BEFORE |
There was a problem hiding this comment.
Suggested change
| null_precedence = [plc.types.NullOrder.AFTER] * len(source_columns) | |
| for idx, val in enumerate(null_position): | |
| if val: | |
| null_precedence[idx] = plc.types.NullOrder.BEFORE | |
| null_precedence = [ | |
| plc.types.NullOrder.BEFORE if val else plc.types.NullOrder.AFTER | |
| ] |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #17317
Checklist