Use NANOARROW_DEBUG in clang-tidy builds

[vyasr]

Description

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[vyasr]

/ok to test

[vyasr]

/ok to test

[vyasr]

/ok to test

[vyasr]

/ok to test

[vyasr]

/ok to test

[vyasr]

/ok to test

[vyasr]

/ok to test

[vyasr]

/ok to test

[paleolimbot]

Just a suggestion that might or might not do the trick. You could also try a higher level -DCMAKE_CXX_FLAGS_RELEASE=-DNANOARROW_DEBUG from cpp_linters.sh. If you have access to compile_commands.json, it might be worth checking that it actually contains -DNANOARROW_DEBUG for the files that are giving you errors.

[vyasr]

/ok to test

[vyasr]

@paleolimbot unfortunately yeah we're still seeing it with that change.

[vyasr]

I should note that cudf is no longer running clang-tidy on tests, only our source, so we can drop our nanoarrow patching regardless of the outcome of other discussions in this thread.

[paleolimbot]

Oh no! I will try to make a minimal reproducer tomorrow...I see NANOARROW_DEBUG in the command so it's definitely making it there. You all aren't the last people that are going to want to run clang-tidy on something that includes nanoarrow and we need to figure it out at some point.

[vyasr]

Sounds good. If it's helpful I can push out the other changes in this PR that simplify things and then you can use this branch to debug from instead of the previous one I had created.