Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dask>=2024.11.2 in Dask cuDF #17439

Merged
merged 13 commits into from
Nov 27, 2024

Conversation

rjzamora
Copy link
Member

Description

This updates Dask cuDF so that we can unpin from 2024.11.2 for 25.02 development in

TODO: Create a branch in rapids-dask-dependency to unpin from 2024.11.2 (to demonstrate that CI passes).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added bug Something isn't working dask Dask issue non-breaking Non-breaking change labels Nov 25, 2024
@rjzamora rjzamora self-assigned this Nov 25, 2024
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 25, 2024

This is an alias for `Series.dtype`.
"""
return self.dtype
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out that Pandas uses Series.dtypes as an alias for Series.dtype (and some recent dask-expr code takes advantage of the Sereies<->DataFrame portability of the dtypes attribute).

@rjzamora rjzamora marked this pull request as ready for review November 26, 2024 18:45
@rjzamora rjzamora requested review from a team as code owners November 26, 2024 18:45
@rjzamora rjzamora added the 3 - Ready for Review Ready for review by team label Nov 26, 2024
@rjzamora rjzamora changed the title [WIP] Support dask>=2024.11.2 in Dask cuDF Support dask>=2024.11.2 in Dask cuDF Nov 26, 2024
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor suggestion, otherwise as long as CI passes it looks good. Thanks @rjzamora !

python/cudf/cudf/tests/test_series.py Outdated Show resolved Hide resolved
python/dask_cudf/dask_cudf/_legacy/io/orc.py Outdated Show resolved Hide resolved
python/dask_cudf/dask_cudf/_legacy/io/orc.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cudf changes look good.

@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 27, 2024
@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 2c89dba into rapidsai:branch-25.02 Nov 27, 2024
107 checks passed
@rjzamora rjzamora deleted the dask-post-2024.11.2-support branch November 27, 2024 23:53
rapids-bot bot pushed a commit to rapidsai/rapids-dask-dependency that referenced this pull request Nov 28, 2024
Unpins the `dask`, `dask-expr`, and `distributed` versions for 25.02 development.

Depends on rapidsai/cudf#17439 (**Update**: Now merged).

Authors:
  - Richard (Rick) Zamora (https://github.com/rjzamora)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants