Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change indices for dictionary column to signed integer type #17390

Merged
merged 11 commits into from
Dec 4, 2024
Merged

Change indices for dictionary column to signed integer type #17390

merged 11 commits into from
Dec 4, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Nov 20, 2024 •
edited
Loading

Description

Change the indices type for dictionary column from unsigned to signed integer type.

Closes #17327

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 20, 2024
@davidwendt davidwendt self-assigned this Nov 20, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 22, 2024
@davidwendt davidwendt marked this pull request as ready for review November 23, 2024 00:09
@davidwendt davidwendt requested a review from a team as a code owner November 23, 2024 00:09
@davidwendt davidwendt requested review from bdice and lamarrr November 23, 2024 00:09
bdice
bdice reviewed Nov 25, 2024
View reviewed changes
cpp/src/dictionary/dictionary_factories.cu Outdated Show resolved Hide resolved
cpp/src/dictionary/encode.cu Outdated Show resolved Hide resolved
cpp/src/dictionary/encode.cu Show resolved Hide resolved
cpp/src/interop/from_arrow_device.cu Outdated Show resolved Hide resolved
cpp/tests/interop/nanoarrow_utils.hpp Outdated Show resolved Hide resolved
@davidwendt davidwendt added breaking Breaking change and removed non-breaking Non-breaking change labels Nov 25, 2024
@davidwendt davidwendt requested a review from bdice December 2, 2024 21:28
PointKernel
PointKernel approved these changes Dec 3, 2024
View reviewed changes
cpp/src/dictionary/dictionary_factories.cu Outdated Show resolved Hide resolved
bdice
bdice approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 86d833b into rapidsai:branch-25.02 Dec 4, 2024
105 checks passed
@davidwendt davidwendt deleted the dictionary-indices branch December 4, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamarrr lamarrr lamarrr approved these changes

@PointKernel PointKernel PointKernel approved these changes

@bdice bdice bdice approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Arrow Dictionary indices to not prefer Unsigned
4 participants
@davidwendt @bdice @PointKernel @lamarrr