Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cudf._lib.round in favor of inlining pylibcudf #17367

Closed
wants to merge 29 commits into from
Closed

Remove cudf._lib.round in favor of inlining pylibcudf #17367

wants to merge 29 commits into from

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #17317

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 19, 2024
@mroeschke mroeschke self-assigned this Nov 19, 2024
@mroeschke mroeschke requested a review from a team as a code owner November 19, 2024 18:55
@github-actions github-actions bot added the CMake CMake build issue label Nov 19, 2024
@vyasr vyasr changed the base branch from branch-24.12 to branch-25.02 November 20, 2024 16:33
brandon-b-miller and others added 19 commits November 20, 2024 18:57
@brandon-b-miller
Use libcudf_exception_handler throughout pylibcudf.libcudf (rapid…
2e88835 
…sai#17109)

Closes rapidsai#17036

(WIP, generated by a quick `sed` script)

Authors:
  - https://github.com/brandon-b-miller
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: rapidsai#17109
@GPUtester
Merge pull request rapidsai#17382 from rapidsai/branch-24.12
110ed4c 
Forward-merge branch-24.12 into branch-25.02
@rjzamora
Extract GPUEngine config options at translation time (rapidsai#17339
f550ccc 
)

Follow up to rapidsai#16944
That PR added `config: GPUEngine` to the arguments of every `IR.do_evaluate` function. In order to simplify future multi-GPU development, this PR extracts the necessary configuration argument at `IR` translation time instead.

Authors:
  - Richard (Rick) Zamora (https://github.com/rjzamora)
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - https://github.com/brandon-b-miller
  - Lawrence Mitchell (https://github.com/wence-)

URL: rapidsai#17339
@GPUtester
Merge pull request rapidsai#17383 from rapidsai/branch-24.12
2cde861 
Forward-merge branch-24.12 into branch-25.02
@davidwendt
Move strings url_decode benchmarks to nvbench (rapidsai#17328)
04502c8 
Move `cpp/benchmarks/string/url_decode.cu` implementation from google-bench to nvbench.
This benchmark is for the `cudf::strings::url_decode` API.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Muhammad Haseeb (https://github.com/mhaseeb123)
  - Nghia Truong (https://github.com/ttnghia)

URL: rapidsai#17328
@GPUtester
Merge pull request rapidsai#17384 from rapidsai/branch-24.12
f87f017 
Forward-merge branch-24.12 into branch-25.02
@mroeschke
Support pivot with index or column arguments as lists (rapidsai#17373)
332cc06 
closes rapidsai#17360

Technically I suppose this was more of an enhancement since the documentation suggested only a single label was supported, but I'll mark as a bug since the error message was not informative.

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#17373
@GPUtester
Merge pull request rapidsai#17385 from rapidsai/branch-24.12
cd0c0d0 
Forward-merge branch-24.12 into branch-25.02
@davidwendt
Move strings repeat benchmarks to nvbench (rapidsai#17304)
d927992 
Moves the `cpp/benchmarks/string/repeat_strings.cpp` implementation from google-bench to nvbench.
This covers the overloads of the `cudf::strings::repeat_strings` API.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Yunsong Wang (https://github.com/PointKernel)

URL: rapidsai#17304
@GPUtester
Merge pull request rapidsai#17391 from rapidsai/branch-24.12
e52df19 
Forward-merge branch-24.12 into branch-25.02
@pentschev
Add pynvml as a dependency for dask-cudf (rapidsai#17386)
68c4285 
rapidsai#17250 started using `pynvml` but did not add the proper dependency, this change fixes the missing dependency.

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - https://github.com/jakirkham

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - https://github.com/jakirkham

URL: rapidsai#17386
@vyasr
Ignore errors when testing glibc versions (rapidsai#17389)
0d9e577 
This is likely the easiest fix for avoiding CI errors from this part of the code.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#17389
@jakirkham
Merge branch-24.12 into branch-25.02
c46e9e4
@raydouglass
Merge pull request rapidsai#17395 from jakirkham/branch-25.02-merge-2…
1bfc114 
…4.12

Forward-merge branch-24.12 into branch-25.02
@Matt711
Migrate CSV writer to pylibcudf (rapidsai#17163)
f54c1a5 
Apart of rapidsai#15162

Authors:
  - Matthew Murray (https://github.com/Matt711)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Matthew Roeschke (https://github.com/mroeschke)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Lawrence Mitchell (https://github.com/wence-)

URL: rapidsai#17163
@GPUtester
Merge pull request rapidsai#17401 from rapidsai/branch-24.12
ffeea05 
Forward-merge branch-24.12 into branch-25.02
@shrshi
Expose stream-ordering to interop APIs (rapidsai#17397)
78db66b 
Adds stream parameter to
```
cudf::from_dlpack
cudf::to_dlpack
```

Added stream gtests to verify correct stream forwarding.

Reference: rapidsai#13744

Authors:
  - Shruti Shivakumar (https://github.com/shrshi)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Tianyu Liu (https://github.com/kingcrimsontianyu)

URL: rapidsai#17397
@bdice
Document interpreter install command for cudf.pandas (rapidsai#17358)
b2419dd 
This PR adds documentation for `cudf.pandas.install()` alongside the usage instructions for `%load_ext cudf.pandas` and `-m cudf.pandas` methods.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: rapidsai#17358
@galipremsagar @vyasr
@Matt711 @wence-
Enable unified memory by default in cudf_polars (rapidsai#17375)
305182e 
This PR enables Unified memory as the default memory resource for
`cudf_polars`

---------

Co-authored-by: Vyas Ramasubramani <[email protected]>
Co-authored-by: Vyas Ramasubramani <[email protected]>
Co-authored-by: Matthew Murray <[email protected]>
Co-authored-by: Lawrence Mitchell <[email protected]>
Co-authored-by: Matthew Murray <[email protected]>
GPUtester and others added 8 commits November 22, 2024 09:45
@GPUtester
Merge pull request rapidsai#17417 from rapidsai/branch-24.12
2827a03 
Forward-merge branch-24.12 into branch-25.02
@mroeschke
Add write_parquet to pylibcudf (rapidsai#17263)
53e4525 
Broken off from rapidsai#17252 since also replacing cudf Python's `write_parquet` usage would have made the PR fairly large.

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)
  - Lawrence Mitchell (https://github.com/wence-)
  - Matthew Murray (https://github.com/Matt711)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)
  - Matthew Murray (https://github.com/Matt711)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#17263
@bdice
Run clang-tidy checks in PR CI (rapidsai#17407)
5a89d00 
We discussed clang-tidy during the cuDF brown bag session. We decided to enable clang-tidy in PR CI and follow up by enabling more checks later.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - David Wendt (https://github.com/davidwendt)

URL: rapidsai#17407
@mroeschke
Remove cudf._lib.transpose in favor of inlining pylibcudf (rapidsai#1…
881afd1 
…7365)

Contributes to rapidsai#17317

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Matthew Murray (https://github.com/Matt711)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: rapidsai#17365
@PointKernel
Update xxhash_64 to utilize the cuco equivalent implementation (rapid…
092fdff 
…sai#17393)

This PR updates `xxhash_64` to leverage the cuco equivalent implementation and makes it available as a cudf detail utility, as requested by @mhaseeb123. Additionally, it fixes a minor issue in the `murmurhash3_x64_128.cuh` header by adding the missing `#pragma once` directive.

Authors:
  - Yunsong Wang (https://github.com/PointKernel)

Approvers:
  - Muhammad Haseeb (https://github.com/mhaseeb123)
  - Nghia Truong (https://github.com/ttnghia)
  - David Wendt (https://github.com/davidwendt)

URL: rapidsai#17393
@zeroshade
Fix Debug-mode failing Arrow test (rapidsai#17405)
8b7127f 
Fixes rapidsai#17153 by fixing the appropriate element nullability data types

Authors:
  - Matt Topol (https://github.com/zeroshade)

Approvers:
  - Yunsong Wang (https://github.com/PointKernel)
  - David Wendt (https://github.com/davidwendt)

URL: rapidsai#17405
@mroeschke
Move cudf._lib.search to cudf.core._internals (rapidsai#17411)
d1d4420 
Contributes to rapidsai#17317

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#17411
@mroeschke
Merge branch 'cudf/_lib/round' of https://github.com/mroeschke/cudf i…
64e389d 
…nto cudf/_lib/round
@mroeschke mroeschke requested review from a team as code owners November 23, 2024 01:31
@mroeschke mroeschke requested a review from davidwendt November 23, 2024 01:31
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 23, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Nov 23, 2024
@mroeschke mroeschke closed this Nov 23, 2024
@mroeschke mroeschke deleted the cudf/_lib/round branch November 23, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@davidwendt davidwendt Awaiting requested review from davidwendt davidwendt is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@mroeschke mroeschke

Labels
CMake CMake build issue cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.