Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cudf._lib.timezone in favor of inlining pylibcudf #17366

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Remove cudf._lib.timezone in favor of inlining pylibcudf #17366

merged 5 commits into from
Nov 26, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #17317

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 19, 2024
@mroeschke mroeschke requested a review from a team as a code owner November 19, 2024 18:54
@mroeschke mroeschke self-assigned this Nov 19, 2024
@github-actions github-actions bot added the CMake CMake build issue label Nov 19, 2024
@mroeschke mroeschke changed the base branch from branch-24.12 to branch-25.02 November 20, 2024 00:50
@mroeschke mroeschke requested review from a team as code owners November 20, 2024 00:50
@mroeschke mroeschke changed the base branch from branch-25.02 to branch-24.12 November 20, 2024 00:50
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Nov 20, 2024
@mroeschke mroeschke changed the base branch from branch-24.12 to branch-25.02 November 20, 2024 01:10
@github-actions github-actions bot removed libcudf Affects libcudf (C++/CUDA) code. Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas labels Nov 20, 2024
@github-actions github-actions bot removed cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Nov 20, 2024
@ttnghia ttnghia removed the request for review from a team November 22, 2024 21:08
jameslamb
jameslamb approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from the narrow perspective of packaging... agree that if we're deleting timezone.pyx, it needs to be removed from the list of sources in CMakeLists.txt.

Will defer to the other reviewers on the substance of this PR.

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ccc8833 into rapidsai:branch-25.02 Nov 26, 2024
105 checks passed
@mroeschke mroeschke deleted the cudf/_lib/timezone branch November 26, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@bdice bdice bdice approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@shrshi shrshi Awaiting requested review from shrshi shrshi was automatically assigned from rapidsai/cudf-cpp-codeowners

@pmattione-nvidia pmattione-nvidia Awaiting requested review from pmattione-nvidia pmattione-nvidia was automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@mroeschke mroeschke

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @bdice @jameslamb