Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deselect pdsh benchmark test in polars test suite #17336

Closed

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Nov 15, 2024

Description

These tests use a dbgen binary in the polars repo. This binary might not have been compiled with a compatible libc as the CI image uses.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

These tests use a dbgen binary in the polars repo. This binary might
not have been compiled with a compatible libc as the CI image uses.
@wence- wence- requested a review from a team as a code owner November 15, 2024 15:21
@wence- wence- requested a review from jameslamb November 15, 2024 15:21
@wence- wence- added bug Something isn't working non-breaking Non-breaking change labels Nov 15, 2024
@wence-
Copy link
Contributor Author

wence- commented Nov 15, 2024

We didn't notice this until turning on nightlies because PR CI doesn't run with the old GLIBC CI image combo.

@davidwendt
Copy link
Contributor

@bdice
Copy link
Contributor

bdice commented Nov 15, 2024

More information:

$ nm dbgen | grep GLIBC | cut -d "@" -f 2 | sort --version-sort | uniq
GLIBC_2.2.5
GLIBC_2.4
GLIBC_2.7
GLIBC_2.14
GLIBC_2.33
GLIBC_2.34

Rocky Linux 8 ships with glibc 2.28, so the symbols from 2.33 and 2.34 are not compatible.

@vyasr
Copy link
Contributor

vyasr commented Nov 15, 2024

I've added a more targeted removal in #17320 as discussed offline, so I think we can close this PR in favor of that one.

@wence-
Copy link
Contributor Author

wence- commented Nov 18, 2024

Using #17320 instead.

@wence- wence- closed this Nov 18, 2024
@wence- wence- deleted the wence/fix/skip-polars-pdsh-tests branch November 18, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants