Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move strings url_decode benchmarks to nvbench #17328

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Move strings url_decode benchmarks to nvbench #17328

merged 8 commits into from
Nov 20, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Move cpp/benchmarks/string/url_decode.cu implementation from google-bench to nvbench.
This benchmark is for the cudf::strings::url_decode API.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 14, 2024
@davidwendt davidwendt self-assigned this Nov 14, 2024
@github-actions github-actions bot added the CMake CMake build issue label Nov 14, 2024
@davidwendt davidwendt marked this pull request as ready for review November 15, 2024 13:33
@davidwendt davidwendt requested a review from a team as a code owner November 15, 2024 13:33
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 04502c8 into rapidsai:branch-24.12 Nov 20, 2024
115 checks passed
@davidwendt davidwendt deleted the strings-urldecode-nvbench branch November 20, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@ttnghia ttnghia ttnghia approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @ttnghia @mhaseeb123