Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose stream-ordering to groupby APIs #17324

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

shrshi
Copy link
Contributor

@shrshi shrshi commented Nov 14, 2024

Description

Adds stream parameter to

cudf::groupby::scan
cudf::groupby::aggregate
cudf::groupby::shift
cudf::groupby::get_groups
cudf::groupby::replace_nulls

Added stream gtests to verify correct stream forwarding.

Reference: #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 14, 2024
@shrshi shrshi added feature request New feature or request non-breaking Non-breaking change labels Nov 14, 2024
@shrshi shrshi marked this pull request as ready for review November 14, 2024 11:42
@shrshi shrshi requested a review from a team as a code owner November 14, 2024 11:42
@shrshi shrshi changed the base branch from branch-24.12 to branch-25.02 November 20, 2024 09:38
@shrshi
Copy link
Contributor Author

shrshi commented Nov 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit 8d8cd78 into rapidsai:branch-25.02 Nov 25, 2024
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants