Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put a ceiling on cuda-python #17264

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Nov 7, 2024

Description

Follow-up to #17253

Contributes to rapidsai/build-planning#116

That PR used != requirements to skip a particular version of cuda-python that cudf and pylibcudf were incompatible with. A newer version of cuda-python (12.6.2 for CUDA 12, 11.8.5 for CUDA 11) was just released, and it also causes some build issues for RAPIDS libraries: rapidsai/cuvs#445 (comment)

To unblock CI across RAPIDS, this proposes temporarily switching to ceilings on the cuda-python dependency here.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 7, 2024
@jameslamb jameslamb requested a review from vyasr November 7, 2024 03:02
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Nov 7, 2024
@jameslamb jameslamb changed the title Put a ceiling on cuda-python WIP: Put a ceiling on cuda-python Nov 7, 2024
@vyasr vyasr changed the title WIP: Put a ceiling on cuda-python Put a ceiling on cuda-python Nov 7, 2024
@vyasr vyasr marked this pull request as ready for review November 7, 2024 03:31
@vyasr vyasr requested a review from a team as a code owner November 7, 2024 03:31
@vyasr vyasr requested a review from bdice November 7, 2024 03:31
@bdice
Copy link
Contributor

bdice commented Nov 7, 2024

Looks like CI is still failing. I am not sure how to fix this immediately. We’ll need to diagnose tomorrow…

ImportError while loading conftest '/__w/cudf/cudf/python/pylibcudf/pylibcudf/tests/conftest.py'.
conftest.py:13: in <module>
    import pylibcudf as plc
/pyenv/versions/3.12.7/lib/python3.12/site-packages/pylibcudf/__init__.py:13: in <module>
    from . import (
binaryop.pyx:1: in init pylibcudf.binaryop
    ???
column.pyx:1: in init pylibcudf.column
    ???
/pyenv/versions/3.12.7/lib/python3.12/site-packages/rmm/__init__.py:17: in <module>
    from rmm import mr
/pyenv/versions/3.12.7/lib/python3.12/site-packages/rmm/mr.py:14: in <module>
    from rmm.pylibrmm.memory_resource import (
/pyenv/versions/3.12.7/lib/python3.12/site-packages/rmm/pylibrmm/__init__.py:15: in <module>
    from .device_buffer import DeviceBuffer
device_buffer.pyx:1: in init rmm.pylibrmm.device_buffer
    ???
E   ModuleNotFoundError: No module named 'cuda.bindings'

@vyasr
Copy link
Contributor

vyasr commented Nov 7, 2024

It's failing because we need a new rmm build. I was waiting for rmm and kvikio to publish. The latter just finished, so I'm restarting CI. This should pass now.

@vyasr
Copy link
Contributor

vyasr commented Nov 7, 2024

/merge

@rapids-bot rapids-bot bot merged commit 29484cb into rapidsai:branch-24.12 Nov 7, 2024
129 of 130 checks passed
@jameslamb jameslamb deleted the more-cuda-python branch November 7, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants