Fixed unused attribute compilation error for GCC 13 #17188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
approved these changes
Oct 28, 2024
pmattione-nvidia
approved these changes
Oct 28, 2024
lamarrr
added
improvement
|
/merge |
shrshi
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With
decltype(&pclose)for the destructor type of theunique_ptr, gcc makes the signature inherit the attributes ofpclose. The compiler then ignores this attribute as it doesn't apply within the context with a warning, and since we have-Werroron for ignored attributes, the build fails.This happens on gcc 13.2.0.
Checklist