Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variable in internal merge_tdigests utility #17151

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Remove unused variable in internal merge_tdigests utility #17151

merged 1 commit into from
Oct 24, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Oct 23, 2024 •
edited
Loading

Description

Removes unused variable that contains host copy of the group_offsets data.
This host variable appears to have been made obsolete by a combination of #16897 and #16780
Found while working on #17149

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 23, 2024
@davidwendt davidwendt self-assigned this Oct 23, 2024
@davidwendt davidwendt requested a review from a team as a code owner October 23, 2024 18:45
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b75036b into rapidsai:branch-24.12 Oct 24, 2024
107 checks passed
@davidwendt davidwendt deleted the remove-unused-parameter branch October 24, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@ttnghia ttnghia ttnghia approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @ttnghia @mhaseeb123