use rapids-generate-pip-constraints to pin to oldest dependencies in CI #17131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
2 - In Progress
jameslamb
removed
2 - In Progress
jameslamb
changed the title
bdice
approved these changes
Oct 31, 2024
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Nov 7, 2024
…CI (#1716) Follow-up to #1613 Similar to rapidsai/cudf#17131 Proposes using the new `rapids-generate-pip-constraints` tool from `gha-tools` to generate a list of pip constraints pinning to the oldest supported verisons of dependencies here. ## Notes for Reviewers ### How I tested this `wheel-tests`: * oldest-deps: numpy 1.x ([build link](https://github.com/rapidsai/rmm/actions/runs/11620907528/job/32364032641?pr=1716#step:8:106)) * latest-deps: numpy 2.x ([build link](https://github.com/rapidsai/rmm/actions/runs/11620907528/job/32364032835?pr=1716#step:8:104)) And the testing of the general approach in rapidsai/gha-tools#114 (comment) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #16570 (comment)
Proposes using the new
rapids-generate-pip-constraintstool fromgha-toolsto generate a list of pip constraints pinning to the oldest supported verisons of dependencies here.Notes for Reviewers
How I tested this
rapidsai/gha-tools#114 (comment)
You can also see one the most recent
wheel-tests-cudfbuilds here:Checklist