Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pylibcudf/libcudf/wrappers/decimals to pylibcudf/libcudf/fixed_point #17048

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Move pylibcudf/libcudf/wrappers/decimals to pylibcudf/libcudf/fixed_point #17048

merged 3 commits into from
Oct 11, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Oct 10, 2024 •
edited
Loading

Description

Contributes to #15162

I don't think there are any types in this file that needs to be exposed on the Python side; they're just used internally in pylibcudf.

Also moves this to libcudf/fixed_point matching the libcudf location more closely

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package labels Oct 10, 2024
@mroeschke mroeschke requested a review from a team as a code owner October 10, 2024 18:13
@mroeschke mroeschke requested review from vyasr and bdice October 10, 2024 18:13
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 10, 2024
@mroeschke mroeschke mentioned this pull request Oct 10, 2024
Open
vyasr
vyasr approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't need to review again unless my question doesn't have a simple answer 🙂

python/pylibcudf/pylibcudf/libcudf/fixed_point/__init__.pyx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file necessary, or can it be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. It's not needed.

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 097778e into rapidsai:branch-24.12 Oct 11, 2024
102 checks passed
@mroeschke mroeschke deleted the pylibcudf/wrappers/decimal branch October 11, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr