Pylibcudf: pack and unpack #17012
Merged
Pylibcudf: pack and unpack #17012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
improvement
github-actions
bot
added
Python
Matt711
reviewed
Oct 8, 2024
There was a problem hiding this comment.
xref #16953. Do you also plan to plumb your changes through cudf python (eg. copying.pyx)
|
Sorry @Matt711, didn't see #16953.
No, not in this PR. The plan is to include the bindings needed to serialize cudf.polars' |
No worries, I'll probably hold off on #16953, and get any missing pieces from |
madsbk
commented
Oct 8, 2024
madsbk
force-pushed
the
pylibcudf_pack_and_unpack
branch
from
67f371d to
851e725
Compare
madsbk
force-pushed
the
pylibcudf_pack_and_unpack
branch
from
851e725 to
9d5491b
Compare
bdice
reviewed
Oct 9, 2024
wence-
reviewed
Oct 9, 2024
Co-authored-by: Bradley Dice <[email protected]>
mroeschke
reviewed
Oct 10, 2024
wence-
reviewed
Oct 10, 2024
mroeschke
approved these changes
Oct 11, 2024
wence-
reviewed
Oct 11, 2024
Co-authored-by: Lawrence Mitchell <[email protected]>
wence-
approved these changes
Oct 11, 2024
We can't contiguous-split a Column.
|
/merge |
madsbk
added a commit
to madsbk/cudf
that referenced
this pull request
Oct 11, 2024
madsbk
added a commit
to madsbk/cudf
that referenced
this pull request
Oct 12, 2024
madsbk
added a commit
to madsbk/cudf
that referenced
this pull request
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding python bindings to
cudf::pack(),cudf::unpack(), andcudf::packed_columns.This is the first step to support serialization of cudf.polars' IR.
cc. @wence- @rjzamora
Checklist