Control whether a file data source memory-maps the file with an environment variable #17004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
feature request
ttnghia
reviewed
Oct 8, 2024
ttnghia
reviewed
Oct 8, 2024
ttnghia
reviewed
Oct 8, 2024
ttnghia
reviewed
Oct 8, 2024
…fea-mmap-env-vars
ttnghia
approved these changes
Oct 8, 2024
cpp/src/io/utilities/datasource.cpp
Outdated
| { | ||
| if (_map_addr == nullptr) { return false; } | ||
|
|
||
| auto const policy = getenv_or("LIBCUDF_MMAP_REGISTER_ENABLED", std::string{"AUTO"}); |
There was a problem hiding this comment.
Just a comment: In a future improvement, boolean type handling could be made more flexible by allowing both letter cases and supporting common key words such as "yes", "true", similar to what KvikIO does here.
kingcrimsontianyu
approved these changes
Oct 9, 2024
…fea-mmap-env-vars
…fea-mmap-env-vars
vuule
changed the title
vuule
changed the title
|
Re-requested reviews because the scope changed (got smaller) since the PR was approved. |
ttnghia
approved these changes
Oct 17, 2024
kingcrimsontianyu
approved these changes
Oct 18, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an environment variable,
LIBCUDF_MMAP_ENABLED, to control whether we memory map the input file in the data source.Checklist