Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string.convert.convert_ipv4 APIs to pylibcudf #16994

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Add string.convert.convert_ipv4 APIs to pylibcudf #16994

merged 3 commits into from
Oct 5, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package labels Oct 3, 2024
@mroeschke mroeschke requested a review from a team as a code owner October 3, 2024 21:16
@mroeschke mroeschke requested review from wence- and Matt711 October 3, 2024 21:16
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Oct 3, 2024
@mroeschke mroeschke mentioned this pull request Oct 3, 2024
Open
vyasr
vyasr approved these changes Oct 4, 2024
View reviewed changes
python/pylibcudf/pylibcudf/libcudf/strings/convert/convert_ipv4.pxd Show resolved Hide resolved
python/pylibcudf/pylibcudf/strings/convert/convert_ipv4.pyx
Parameters
----------
integers : Column
Integer (uint32) column to convert.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isays uint32 whereas ipv4_to_integers above says it produces int32. Should these be the same, or is one really unsigned while the other is signed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was a documentation mistake on my end. ipv4_to_integers should say it returns uint32 integers (matching the cpp docstring and the unit test in this PR)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK cool yes please match those when you resolve conflicts, then you are good to go.

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 33b8dfa into rapidsai:branch-24.12 Oct 5, 2024
99 checks passed
@mroeschke mroeschke deleted the pylibcudf/strings/convert_ipv4 branch October 5, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr