Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string.convert_floats APIs to pylibcudf #16990

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Add string.convert_floats APIs to pylibcudf #16990

merged 6 commits into from
Oct 9, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package labels Oct 3, 2024
@mroeschke mroeschke requested a review from a team as a code owner October 3, 2024 17:37
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Oct 3, 2024
@mroeschke mroeschke mentioned this pull request Oct 3, 2024
Open
brandon-b-miller
brandon-b-miller approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, are we missing a strings/convert section of our pylibcudf API docs?

@mroeschke
Copy link
Contributor Author

are we missing a strings/convert section of our pylibcudf API docs?

Ah nice catch. Appears we are. I can add this in one of my other string/convert PRs

@vyasr vyasr mentioned this pull request Oct 9, 2024
Merged
3 tasks
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 3791c8a into rapidsai:branch-24.12 Oct 9, 2024
102 checks passed
@mroeschke mroeschke deleted the pylibcudf/strings/convert_floats branch October 9, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @brandon-b-miller