-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Document limitation using cudf.pandas
proxy arrays
#16955
Merged
rapids-bot
merged 7 commits into
rapidsai:branch-24.12
from
Matt711:doc/cudf-pandas-interop-numpy-C-api
Oct 9, 2024
Merged
[DOC] Document limitation using cudf.pandas
proxy arrays
#16955
rapids-bot
merged 7 commits into
rapidsai:branch-24.12
from
Matt711:doc/cudf-pandas-interop-numpy-C-api
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
added
non-breaking
Non-breaking change
cudf.pandas
Issues specific to cudf.pandas
labels
Sep 30, 2024
vyasr
reviewed
Oct 2, 2024
Matt711
changed the title
[DOC] Document limitation using
[DOC] Document limitation using Oct 3, 2024
cudf.pandas
and functions using NumPy's C APIcudf.pandas
proxy arrays
vyasr
reviewed
Oct 4, 2024
mroeschke
reviewed
Oct 8, 2024
mroeschke
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-blocking comment. LGTM
vyasr
approved these changes
Oct 9, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When instantiating a
cudf.pandas
proxy array, a DtoH transfer occurs so that the data buffer is set correctly. We do this because functions which utilize NumPy's C API can utilize the data buffer directly instead of going through__array__
. This PR documents this limitation.Checklist