Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply clang-tidy autofixes #16949

Merged
merged 3 commits into from
Sep 28, 2024
Merged

Apply clang-tidy autofixes #16949

merged 3 commits into from
Sep 28, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Sep 27, 2024

Description

With the last few clang-tidy PRs merged, clang-tidy now completes successfully enough that autofixes work again. This is the result of an autofix pass.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 27, 2024
@vyasr vyasr self-assigned this Sep 27, 2024
@vyasr vyasr requested a review from a team as a code owner September 27, 2024 21:06
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 27, 2024
karthikeyann
karthikeyann reviewed Sep 27, 2024
View reviewed changes
cpp/src/io/functions.cpp Show resolved Hide resolved
cpp/tests/interop/to_arrow_test.cpp Outdated Show resolved Hide resolved
cpp/tests/io/csv_test.cpp Outdated Show resolved Hide resolved
karthikeyann
karthikeyann approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vyasr
Copy link
Contributor Author

vyasr commented Sep 28, 2024

/merge

@rapids-bot rapids-bot bot merged commit 1ad8ded into rapidsai:branch-24.12 Sep 28, 2024
100 checks passed
@vyasr vyasr deleted the feat/clang_tidy_4 branch September 28, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

@kingcrimsontianyu kingcrimsontianyu Awaiting requested review from kingcrimsontianyu kingcrimsontianyu is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @bdice @karthikeyann @davidwendt