Add string.wrap APIs to pylibcudf #16935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
improvement
github-actions
bot
added
Python
vyasr
approved these changes
Oct 2, 2024
| None, | ||
| ] | ||
| ) | ||
| result = plc.strings.wrap.wrap(plc.interop.from_arrow(pa_array), 12) |
There was a problem hiding this comment.
Minor nit: saving 12 as a variable would be better than hardcoding it twice.
There was a problem hiding this comment.
Will include this change in #16971
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
#16971) Contributes to #15162 Also address a review in #16935 (comment) This also modifies some `format` arguments in `convert_datetime.pyx` to accept `str` instead of `bytes` (`const string&`) to align more with Python. Let me know if you prefer to change this back Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #16971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #15162
Checklist