Parse newline as whitespace character while tokenizing JSONL inputs with non-newline delimiter #16923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrshi
added
bug
shrshi
changed the title
lamarrr
reviewed
Sep 26, 2024
lamarrr
reviewed
Sep 26, 2024
lamarrr
approved these changes
Sep 26, 2024
vuule
reviewed
Sep 26, 2024
| d_scalar.data(), static_cast<size_t>(d_scalar.size())}; | ||
|
|
||
| // Parse the JSON and get the token stream | ||
| auto [d_tokens_gpu, d_token_indices_gpu] = cuio_json::detail::get_token_stream( |
There was a problem hiding this comment.
is there a way to verify correctness using the output of read_json?
There was a problem hiding this comment.
Yes, the JsonReaderTest.ViableDelimiterNewlineWS gtest in json_test.cpp verifies the correctness of the table created by read_json for null delimiter.
Since this delimiter bug fix only affects the PDA in the tokenization step, I wanted to add an additional test that directly checks the output of get_token_stream.
vuule
approved these changes
Sep 27, 2024
|
/merge |
shrshi
added a commit
to shrshi/cudf
that referenced
this pull request
Sep 27, 2024
…ith non-newline delimiter (rapidsai#16923) Addresses rapidsai#16915 Authors: - Shruti Shivakumar (https://github.com/shrshi) Approvers: - Basit Ayantunde (https://github.com/lamarrr) - Karthikeyan (https://github.com/karthikeyann) - Vukasin Milovanovic (https://github.com/vuule) URL: rapidsai#16923
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #16915
Checklist