Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous use of std::vector for std::future #16829

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Remove superfluous use of std::vector for std::future #16829

merged 4 commits into from
Sep 27, 2024

Conversation

kingcrimsontianyu
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu commented Sep 18, 2024 •
edited
Loading

Description

This PR addresses #16888 , where a superfluous use of std::vector should be removed.

closes #16888

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 18, 2024
@kingcrimsontianyu kingcrimsontianyu added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 18, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 24, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@kingcrimsontianyu kingcrimsontianyu marked this pull request as ready for review September 24, 2024 13:43
@kingcrimsontianyu kingcrimsontianyu requested a review from a team as a code owner September 24, 2024 13:43
@kingcrimsontianyu kingcrimsontianyu self-assigned this Sep 24, 2024
@kingcrimsontianyu kingcrimsontianyu changed the title Simplify the use of std::future Remove superfluous use of std::vector for std::future Sep 24, 2024
@kingcrimsontianyu kingcrimsontianyu changed the base branch from branch-24.10 to branch-21.12 September 24, 2024 18:33
@kingcrimsontianyu kingcrimsontianyu requested review from a team as code owners September 24, 2024 18:33
@kingcrimsontianyu kingcrimsontianyu requested review from Matt711 and removed request for a team September 24, 2024 18:33
@kingcrimsontianyu kingcrimsontianyu changed the base branch from branch-21.12 to branch-24.10 September 24, 2024 18:33
@kingcrimsontianyu kingcrimsontianyu changed the base branch from branch-24.10 to branch-24.12 September 24, 2024 18:34
@raydouglass raydouglass removed request for a team September 26, 2024 17:04
@vyasr
Copy link
Contributor

vyasr commented Sep 26, 2024

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Sep 27, 2024

/merge

@rapids-bot rapids-bot bot merged commit 4018d31 into rapidsai:branch-24.12 Sep 27, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@pmattione-nvidia pmattione-nvidia Awaiting requested review from pmattione-nvidia pmattione-nvidia is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 was automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@kingcrimsontianyu kingcrimsontianyu

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
libcudf
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Remove superfluous use of std::vector for std::future
4 participants
@kingcrimsontianyu @vyasr @ttnghia @vuule