Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Polars docs #16820

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Improve Polars docs #16820

merged 4 commits into from
Sep 23, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Sep 17, 2024

Description

This PR improves the docs by reducing the size of the Polars heading (too many words) and tightening up the writing of the docs page.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested review from a team as code owners September 17, 2024 18:51
@bdice bdice changed the base branch from branch-24.10 to branch-24.08 September 17, 2024 18:52
@bdice bdice added doc Documentation non-breaking Non-breaking change labels Sep 17, 2024
@bdice
Copy link
Contributor Author

bdice commented Sep 17, 2024 •
edited
Loading

We can target branch-24.08 or branch-24.10 with this PR (it would be merged after #16813). Reviewers, please weigh in on that decision.

galipremsagar
galipremsagar approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with merging into 24.08

quasiben
quasiben approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@quasiben quasiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bdice bdice mentioned this pull request Sep 19, 2024
Merged
wence-
wence- approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdice

@wence-
Copy link
Contributor

wence- commented Sep 20, 2024

The docs builds are failing because the artifact download is attempting to grab 3.12 artifacts, but those don't exist:

https://github.com/rapidsai/cudf/actions/runs/10950652331/job/30437458677?pr=16820#step:9:139
https://github.com/rapidsai/cudf/actions/runs/10950652331/job/30437458677?pr=16820#step:9:401

I don't know what part of the workflow is controlling the environment variable RAPIDS_PY_VERSION

@wence-
Copy link
Contributor

wence- commented Sep 20, 2024

Oh, is it due to this? rapidsai/ci-imgs@0b91078

@bdice
Copy link
Contributor Author

bdice commented Sep 20, 2024

Yes, it's due to latest tags changing. I'll see what to do here.

@bdice
Copy link
Contributor Author

bdice commented Sep 21, 2024

I pinned the CI images to a Python 3.11 version. We'll need to undo that change when this is forward-merged.

@bdice
Copy link
Contributor Author

bdice commented Sep 21, 2024 •
edited
Loading

The docs render fine.

However, something strange happened with the ARM CUDA 12 CI jobs and they spat out 114 megabytes of logs, seemingly to do with FNV hash functions in Numba. I'm unsure why this would erupt into so much output... I have no explanation, so I will rerun CI and hope for the best.

edit: It looks like the same thing is happening again. This can be investigated next week.

@raydouglass raydouglass merged commit 0870051 into rapidsai:branch-24.08 Sep 23, 2024
77 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@quasiben quasiben quasiben approved these changes

@wence- wence- wence- approved these changes

@beckernick beckernick Awaiting requested review from beckernick

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller

@singhmanas1 singhmanas1 Awaiting requested review from singhmanas1

Assignees
No one assigned
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdice @wence- @quasiben @galipremsagar @raydouglass