-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Polars docs #16820
Improve Polars docs #16820
Conversation
We can target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with merging into 24.08
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bdice
The docs builds are failing because the artifact download is attempting to grab 3.12 artifacts, but those don't exist: https://github.com/rapidsai/cudf/actions/runs/10950652331/job/30437458677?pr=16820#step:9:139 I don't know what part of the workflow is controlling the environment variable |
Oh, is it due to this? rapidsai/ci-imgs@0b91078 |
Yes, it's due to |
I pinned the CI images to a Python 3.11 version. We'll need to undo that change when this is forward-merged. |
The docs render fine. However, something strange happened with the ARM CUDA 12 CI jobs and they spat out 114 megabytes of logs, seemingly to do with FNV hash functions in Numba. I'm unsure why this would erupt into so much output... I have no explanation, so I will rerun CI and hope for the best. edit: It looks like the same thing is happening again. This can be investigated next week. |
Description
This PR improves the docs by reducing the size of the Polars heading (too many words) and tightening up the writing of the docs page.
Checklist