Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add io_type axis with default PINNED_BUFFER to nvbench PQ multithreaded reader #16809

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Add io_type axis with default PINNED_BUFFER to nvbench PQ multithreaded reader #16809

merged 3 commits into from
Sep 17, 2024

Conversation

mhaseeb123
Copy link
Member

Description

Closes #16758

This PR adds an io_type axis to the benchmarks in PARQUET_MULTITHREAD_READER_NVBENCH with PINNED_BUFFER as default value. More description at #16758.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mhaseeb123 mhaseeb123 self-assigned this Sep 16, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 16, 2024
@mhaseeb123 mhaseeb123 marked this pull request as ready for review September 16, 2024 22:16
@mhaseeb123 mhaseeb123 requested a review from a team as a code owner September 16, 2024 22:16
@mhaseeb123 mhaseeb123 added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 16, 2024
PointKernel
PointKernel approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

One non-blocking nit

cpp/benchmarks/io/parquet/parquet_reader_multithread.cpp Outdated Show resolved Hide resolved
@mhaseeb123
Copy link
Member Author

/merge

@mhaseeb123 mhaseeb123 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Sep 16, 2024
kingcrimsontianyu
kingcrimsontianyu approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@rapids-bot rapids-bot bot merged commit a112f68 into rapidsai:branch-24.10 Sep 17, 2024
97 checks passed
@mhaseeb123 mhaseeb123 deleted the fea-add-io-type-axis-nvbench-pq-multithread-read branch September 17, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@PointKernel PointKernel PointKernel approved these changes

@kingcrimsontianyu kingcrimsontianyu kingcrimsontianyu approved these changes

Assignees

@mhaseeb123 mhaseeb123

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Add io_type axis with PINNED_BUFFER default value to PARQUET_MULTITHREAD_READER_NVBENCH
4 participants
@mhaseeb123 @kingcrimsontianyu @PointKernel @davidwendt