-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strings.combine APIs to pylibcudf #16790
Add strings.combine APIs to pylibcudf #16790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like this API is one where our fused type overloads start to get quite clunky.
I am also concerned about null-preserving usage.
Sorry for the delay here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor docstring suggestions, thanks!
docs/cudf/source/user_guide/api_docs/pylibcudf/strings/index.rst
Outdated
Show resolved
Hide resolved
/merge |
Description
Contributes to #15162
Checklist