Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slice_strings wide strings logic with multi-byte characters #16777

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Fix slice_strings wide strings logic with multi-byte characters #16777

merged 3 commits into from
Sep 11, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Fixes logic error in computing character and byte counts for slice positions in strings with specific pattern of multi-byte characters.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) non-breaking Non-breaking change labels Sep 9, 2024
@davidwendt davidwendt self-assigned this Sep 9, 2024
jlowe
jlowe approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Spark integration tests that were previously failing are now passing with this change.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Sep 10, 2024
@davidwendt davidwendt marked this pull request as ready for review September 10, 2024 15:23
@davidwendt davidwendt requested a review from a team as a code owner September 10, 2024 15:23
@davidwendt davidwendt requested review from zpuller and vuule September 10, 2024 15:23
@davidwendt davidwendt requested a review from vuule September 11, 2024 15:12
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 985f671 into rapidsai:branch-24.10 Sep 11, 2024
98 checks passed
@davidwendt davidwendt deleted the mb-slice-string branch September 11, 2024 17:03
@sameerz
Copy link
Contributor

sameerz commented Sep 14, 2024

Does this close #16768 ?

@davidwendt
Copy link
Contributor Author

Yes, sorry I should have closed that with this merge.

@davidwendt davidwendt mentioned this pull request Sep 15, 2024
Closed
@revans2 revans2 mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@zpuller zpuller zpuller approved these changes

@jlowe jlowe jlowe approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidwendt @sameerz @jlowe @zpuller @vuule