Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow pandas patch version to float in cudf-pandas unit tests #16763

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jameslamb
Copy link
Member

Description

#16745 added support for Python 3.12 in this project.

When that was merged, nightly unit-tests-cudf-pandas jobs on Python 3.12 started failing, with errors from compiling pandas: (build link)

That's only happening because we're running pip install pandas==2.1 in those jobs, which matches exactly pandas==2.1.0, which does not have Python 3.12 wheels on PyPI (https://pypi.org/project/pandas/2.1.0/#files).

Collecting pandas==2.1
  Downloading pandas-2.1.0.tar.gz (4.3 MB)

pandas==2.1.1 DOES have Python 3.12 wheels on PyPI (https://pypi.org/project/pandas/2.1.1/#files).

To fix those jobs, this proposes allowing the patch version of pandas installed in those CI jobs to float:

  • before: pip install pandas==2.1
  • after: pip install pandas==2.1.*

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 6, 2024
@jameslamb jameslamb requested a review from a team as a code owner September 6, 2024 15:45
@@ -91,7 +91,7 @@ IFS=',' read -r -a versions <<< "$output"

for version in "${versions[@]}"; do
echo "Installing pandas version: ${version}"
python -m pip install "numpy>=1.23,<2.0a0" "pandas==${version}"
python -m pip install "numpy>=1.23,<2.0a0" "pandas==${version}.*"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version here is always of the form {major}.{minor}, populated by this script that reads dependencies.yaml:

matching_minors = sorted(set(".".join((str(v.major), str(v.minor))) for v in matching_versions), key=Version)

@jameslamb
Copy link
Member Author

jameslamb commented Sep 6, 2024

pip devcontainers builds are failing because dask-cuda (unsuffixed) is ending up in the install list.

ERROR: No matching distribution found for dask-cuda==24.10.*,>=0.0.0a0

(build link)

Looking into it.

I forgot, dask-cuda should be unsuffixed: https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/dask-cuda/. Maybe this was just a network error, I'll try restarting it.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 8d8faef into rapidsai:branch-24.10 Sep 6, 2024
98 checks passed
@jameslamb jameslamb deleted the fix/pandas-tests branch September 6, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants