Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add support for cudf.NamedAgg #16744

Merged
merged 7 commits into from
Sep 11, 2024
Merged

[FEA] Add support for cudf.NamedAgg #16744

merged 7 commits into from
Sep 11, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Sep 4, 2024

Description

Closes #15118

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added feature request New feature or request Python Affects Python cuDF API. non-breaking Non-breaking change labels Sep 4, 2024
@Matt711 Matt711 self-assigned this Sep 4, 2024
@Matt711 Matt711 requested a review from a team as a code owner September 4, 2024 18:36
@Matt711 Matt711 requested review from vyasr and isVoid September 4, 2024 18:36
@Matt711 Matt711 requested a review from mroeschke September 9, 2024 15:13
mroeschke
mroeschke approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about a test coverage otherwise LGTM

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 10, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Matt711
Copy link
Contributor Author

Matt711 commented Sep 10, 2024

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Sep 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit 4cdb1bf into rapidsai:branch-24.10 Sep 11, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] NamedAgg in groupby context
2 participants
@Matt711 @mroeschke