Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove xfail from torch-cudf.pandas integration test #16705

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Remove xfail from torch-cudf.pandas integration test #16705

merged 4 commits into from
Sep 6, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Aug 30, 2024 •
edited
Loading

Description

The torch test should no longer fail after #16601.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added tests Unit testing for project non-breaking Non-breaking change cudf.pandas Issues specific to cudf.pandas labels Aug 30, 2024
@Matt711 Matt711 self-assigned this Aug 30, 2024
@Matt711 Matt711 requested a review from a team as a code owner August 30, 2024 12:57
@Matt711 Matt711 requested review from wence- and vyasr August 30, 2024 12:57
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 30, 2024
@galipremsagar galipremsagar added the improvement Improvement / enhancement to an existing function label Aug 30, 2024
@Matt711 Matt711 added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 3, 2024
@Matt711
Copy link
Contributor Author

Matt711 commented Sep 3, 2024

We can merge this PR after #16601

@Matt711 Matt711 requested a review from a team as a code owner September 5, 2024 15:13
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 5, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Matt711
Matt711 commented Sep 5, 2024
View reviewed changes
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
@Matt711 Matt711 removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 5, 2024
@Matt711
Copy link
Contributor Author

Matt711 commented Sep 5, 2024

/ok to test

jameslamb
jameslamb approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving you a ci-codeowners approval, expecting a cudf-python-codeowners reviewer will be more aware of the potential risk / impact here.

@Matt711
Copy link
Contributor Author

Matt711 commented Sep 6, 2024

/merge

@rapids-bot rapids-bot bot merged commit f97f61c into rapidsai:branch-24.10 Sep 6, 2024
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@jameslamb jameslamb jameslamb approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
cudf.pandas Issues specific to cudf.pandas improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API. tests Unit testing for project
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Matt711 @jameslamb @mroeschke @galipremsagar