Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of CI artifacts for cudf-polars wheels #16680

Merged
merged 48 commits into from
Sep 17, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Aug 28, 2024

Description

This is the changes that will be in the cudf-polars point release.

wence- and others added 26 commits July 29, 2024 10:48
Use new polars engine config object in cudf-polars callback
## Description
<!-- Provide a standalone description of changes in this PR. -->
<!-- Reference any issues closed by this PR with "closes #1234". -->
<!-- Note: The pull request title will be included in the CHANGELOG. -->

Adapts to IR changes in polars 1.4 and handles nrows/skiprows a little
more correctly.

## Checklist
- [ ] I am familiar with the [Contributing
Guidelines](https://github.com/rapidsai/cudf/blob/HEAD/CONTRIBUTING.md).
- [ ] New or existing tests cover these changes.
- [ ] The documentation is up to date with these changes.

---------

Co-authored-by: Lawrence Mitchell <lmitchell@nvidia.com>
Add support for ``pl.col.str.replace`` and ``pl.col.str.replace_many``

Authors:
  - Thomas Li (https://github.com/lithomas1)

Approvers: None

URL: #16039
contributes to #16478

This implements "cum_min", "cum_max", "cum_prod", "cum_sum"

"cum_count" is not implemented for now, since there's no exact libcudf match (I imagine the non-grouped case is also not used that much but haven't checked).
I suppose we could implement it by creating a column of 1s and copying the null mask over, and doing a cum_sum on that.
Let me know if you want to try that.

Authors:
  - Thomas Li (https://github.com/lithomas1)

Approvers:
  - https://github.com/brandon-b-miller

URL: #16509
Use a key column rather than a placeholder for count agg
polars.from_arrow renames empty column names (see
pola-rs/polars#11632). This causes problems
when round-tripping specially crafted dataframes. Avoid the problem by
constructing the table with fake names and then renaming.
Add support for additional unaryops through `cudf-polars`. 

Closes #16566

---------

Co-authored-by: Lawrence Mitchell <lmitchell@nvidia.com>
Add support for string `strip` in `pylibcudf` and `cudf-polars`.

---------

Co-authored-by: Lawrence Mitchell <lmitchell@nvidia.com>
@wence- wence- added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Aug 28, 2024
Copy link

copy-pr-bot bot commented Aug 28, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. labels Aug 28, 2024
@wence-
Copy link
Contributor Author

wence- commented Sep 5, 2024

/ok to test

This field renaming was due to a recent refactor in (as-yet-unreleased)
polars 1.7.
## Description

We implement a small pytest plugin that defaults the polars engine to
GPU (by monkeypatching `LazyFrame.collect`, yet another reason to have a
global default somehow).

As well as this, we collate all the known failures and classify them.


## Checklist
- [x] I am familiar with the [Contributing
Guidelines](https://github.com/rapidsai/cudf/blob/HEAD/CONTRIBUTING.md).
- [x] New or existing tests cover these changes.
- [x] The documentation is up to date with these changes.
@wence-
Copy link
Contributor Author

wence- commented Sep 6, 2024

/ok to test

1 similar comment
@wence-
Copy link
Contributor Author

wence- commented Sep 9, 2024

/ok to test

@wence- wence- marked this pull request as ready for review September 16, 2024 13:50
@wence- wence- requested review from a team as code owners September 16, 2024 13:50
@wence- wence- requested review from raydouglass, galipremsagar, brandon-b-miller, mythrocks and karthikeyann and removed request for a team September 16, 2024 13:50
@wence- wence- removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 16, 2024
@brandon-b-miller
Copy link
Contributor

/ok to test

Modified the cudf API docs to add a page on cudf pandas detailing - 1)
How to use? 2) How to learn more? 3) How to try on Google Colab?

---------

Co-authored-by: Manas Singh <manass@dt01.aselab.nvidia.com>
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@bdice bdice added feature request New feature or request non-breaking Non-breaking change labels Sep 16, 2024
@bdice
Copy link
Contributor

bdice commented Sep 16, 2024

/ok to test

@brandon-b-miller
Copy link
Contributor

/ok to test

@raydouglass raydouglass merged commit 2607537 into branch-24.08 Sep 17, 2024
76 of 80 checks passed
@wence- wence- deleted the feature/cudf-polars branch September 20, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue cudf.polars Issues specific to cudf.polars feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants