Revise get_reader_filepath_or_buffer to handle a list of data sources
#16613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
added
2 - In Progress
rjzamora
added
3 - Ready for Review
rjzamora
commented
Aug 21, 2024
wence-
reviewed
Aug 22, 2024
…reader_filepath_or_buffer
…reader_filepath_or_buffer
…reader_filepath_or_buffer
vyasr
reviewed
Aug 22, 2024
…reader_filepath_or_buffer
rjzamora
commented
Aug 23, 2024
rjzamora
commented
Aug 23, 2024
vyasr
approved these changes
Aug 23, 2024
rjzamora
commented
Aug 23, 2024
rjzamora
added
5 - Ready to Merge
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Follow up to #16613 Supersedes #16166 Improves remote-IO read performance when multiple files are read at once. Also enables partial IO for remote Parquet files (previously removed in `24.10` by #16589). Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Lawrence Mitchell (https://github.com/wence-) URL: #16657
res-life
pushed a commit
to res-life/cudf
that referenced
this pull request
Sep 11, 2024
…i#16657) Follow up to rapidsai#16613 Supersedes rapidsai#16166 Improves remote-IO read performance when multiple files are read at once. Also enables partial IO for remote Parquet files (previously removed in `24.10` by rapidsai#16589). Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Lawrence Mitchell (https://github.com/wence-) URL: rapidsai#16657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The cudf read APIs (e.g.
cudf.read_parquet,cudf.read_json, etc...) currently iterate over data sources, callingget_reader_filepath_or_bufferon each source independently when multiple files are mapped to the samecudf.DataFrame. This is suboptimal when the data sources are remote-file paths (e.g. in S3). In this case, we should be initiating network transfers for all files in parallel (and as early as possible).This PR makes it easier to optimize multi-file data transfer in follow-up work. It also simplifies and centralizes some of the common logic used by the various read APIs.
Checklist