Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make proxy NumPy arrays pass isinstance check in cudf.pandas" #16586

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Aug 16, 2024

Reverts #16286

@Matt711 Matt711 requested a review from a team as a code owner August 16, 2024 22:34
@Matt711 Matt711 requested review from isVoid and charlesbluca August 16, 2024 22:34
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Aug 16, 2024
@Matt711 Matt711 requested review from vyasr, mroeschke and galipremsagar and removed request for isVoid and charlesbluca August 16, 2024 22:34
@Matt711 Matt711 added bug Something isn't working breaking Breaking change labels Aug 16, 2024
@mroeschke
Copy link
Contributor

Just documenting some offline observations why we're reverting for now.

  1. The cudf-pandas integration tests seem to be failing due to this change. Namely this part of the new proxy base class
    def __array_finalize__(self, obj):
        self._fsproxy_wrapped = getattr(obj, "_fsproxy_wrapped", None)

where obj isn't necessarily always the new proxy base class; therefore, None could be passed into cupy.asarray/cupy.ndarray.get

  1. @vyasr expressed some concern about always performing a DTH transfer of the cupy array in __new__

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (branch-24.10@fd44adc). Learn more about missing BASE report.

Files Patch % Lines
python/cudf/cudf/pandas/fast_slow_proxy.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             branch-24.10   #16586   +/-   ##
===============================================
  Coverage                ?   82.97%           
===============================================
  Files                   ?      182           
  Lines                   ?    28938           
  Branches                ?        0           
===============================================
  Hits                    ?    24012           
  Misses                  ?     4926           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit dd2c12d into branch-24.10 Aug 17, 2024
82 checks passed
@mroeschke mroeschke deleted the revert-16286-feature/numpy-proxying branch August 19, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change bug Something isn't working cudf.pandas Issues specific to cudf.pandas Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants