Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure managed memory is supported in cudf.pandas. #16552

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Ensure managed memory is supported in cudf.pandas. #16552

merged 8 commits into from
Aug 14, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 13, 2024 •
edited
Loading

Description

Currently, WSL users of cudf.pandas can try to enable UVM (managed memory) but it is not supported by the driver. This PR detects whether UVM is supported before enabling a managed memory pool or prefetching.

Closes #16551.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner August 13, 2024 22:27
@bdice bdice requested review from mroeschke and lithomas1 August 13, 2024 22:27
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Aug 13, 2024
lithomas1
lithomas1 reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speedy PR!

python/cudf/cudf/pandas/__init__.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the pylibcudf Issues specific to the pylibcudf package label Aug 13, 2024
@bdice bdice mentioned this pull request Aug 14, 2024
Closed
@bdice bdice force-pushed the ensure-managed-memory-is-supported branch from 60d8b0a to 66ab840 Compare August 14, 2024 16:16
@bdice bdice changed the base branch from branch-24.10 to branch-24.08 August 14, 2024 16:16
vyasr
vyasr approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion to improve the comment, approving assuming that you agree with the change.

docs/cudf/source/cudf_pandas/how-it-works.md Outdated Show resolved Hide resolved
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Aug 14, 2024
@bdice bdice self-assigned this Aug 14, 2024
@wence- @bdice
Add upper bound pin for polars (rapidsai#16442)
d3826ed 
This aligns the polars dependency with the most modern version supported by cudf-polars in this branch.

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: rapidsai#16442
@bdice bdice requested a review from a team as a code owner August 14, 2024 17:44
@bdice bdice requested review from raydouglass and removed request for a team August 14, 2024 17:44
@github-actions github-actions bot added the cudf.polars Issues specific to cudf.polars label Aug 14, 2024
@raydouglass raydouglass merged commit 4961512 into rapidsai:branch-24.08 Aug 14, 2024
81 of 82 checks passed
srinivasyadav18 added a commit to srinivasyadav18/cudf that referenced this pull request Aug 16, 2024
@srinivasyadav18
Revert "Ensure managed memory is supported in cudf.pandas. (rapidsai#…
c7f960e 
…16552)"

This reverts commit 4961512.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lithomas1 lithomas1 lithomas1 approved these changes

@raydouglass raydouglass raydouglass approved these changes

@vyasr vyasr vyasr approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@bdice bdice

Labels
bug Something isn't working cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Consider disabling managed memory in cudf.pandas on WSL2
5 participants
@bdice @vyasr @raydouglass @lithomas1 @wence-