Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register read_parquet and read_csv with dask-expr #16535

Merged
merged 12 commits into from
Aug 13, 2024

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Aug 12, 2024

Description

After dask/dask-expr#1114, Dask cuDF must register specific read_parquet and read_csv functions to be used when query-planning is enabled (the default).

This PR is required for CI to pass with dask>2024.8.0

NOTE: It probably doesn't make sense to add specific tests for this change. Once the 2014.7.1 dask pin is removed, all dask_cudf tests using read_parquet and read_csv will fail without this change...

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added bug Something isn't working 2 - In Progress Currently a work in progress dask Dask issue non-breaking Non-breaking change labels Aug 12, 2024
@rjzamora rjzamora self-assigned this Aug 12, 2024
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 12, 2024
@rjzamora rjzamora marked this pull request as ready for review August 13, 2024 13:24
@rjzamora rjzamora requested a review from a team as a code owner August 13, 2024 13:24
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 13, 2024
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only have a minor suggestion

python/dask_cudf/dask_cudf/backends.py Outdated Show resolved Hide resolved
Co-authored-by: Mads R. B. Kristensen <[email protected]>
@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Aug 13, 2024
@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 5780c4d into rapidsai:branch-24.10 Aug 13, 2024
78 checks passed
@rjzamora rjzamora deleted the dx-parquet-dispatch branch August 13, 2024 21:42
rapids-bot bot pushed a commit to rapidsai/rapids-dask-dependency that referenced this pull request Aug 13, 2024
Unpins dask and distributed for 24.10 development.

~**Blocked by rapidsai/build-planning#88 (Dask no longer supports Python 3.9. Therefore, unpinning too early is a "breaking" change).~

Other Blockers:

- [x] rapidsai/cudf#16535
- [x] dask/dask-expr#1122

Authors:
  - Richard (Rick) Zamora (https://github.com/rjzamora)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants