-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register read_parquet
and read_csv
with dask-expr
#16535
Merged
rapids-bot
merged 12 commits into
rapidsai:branch-24.10
from
rjzamora:dx-parquet-dispatch
Aug 13, 2024
Merged
Register read_parquet
and read_csv
with dask-expr
#16535
rapids-bot
merged 12 commits into
rapidsai:branch-24.10
from
rjzamora:dx-parquet-dispatch
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
added
bug
Something isn't working
2 - In Progress
Currently a work in progress
dask
Dask issue
non-breaking
Non-breaking change
labels
Aug 12, 2024
…x-parquet-dispatch
rjzamora
added
3 - Ready for Review
Ready for review by team
and removed
2 - In Progress
Currently a work in progress
labels
Aug 13, 2024
2 tasks
madsbk
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only have a minor suggestion
rjzamora
commented
Aug 13, 2024
Co-authored-by: Mads R. B. Kristensen <[email protected]>
quasiben
approved these changes
Aug 13, 2024
rjzamora
added
5 - Ready to Merge
Testing and reviews complete, ready to merge
and removed
3 - Ready for Review
Ready for review by team
labels
Aug 13, 2024
/merge |
rapids-bot bot
pushed a commit
to rapidsai/rapids-dask-dependency
that referenced
this pull request
Aug 13, 2024
Unpins dask and distributed for 24.10 development. ~**Blocked by rapidsai/build-planning#88 (Dask no longer supports Python 3.9. Therefore, unpinning too early is a "breaking" change).~ Other Blockers: - [x] rapidsai/cudf#16535 - [x] dask/dask-expr#1122 Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
bug
Something isn't working
dask
Dask issue
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After dask/dask-expr#1114, Dask cuDF must register specific
read_parquet
andread_csv
functions to be used when query-planning is enabled (the default).This PR is required for CI to pass with dask>2024.8.0
NOTE: It probably doesn't make sense to add specific tests for this change. Once the 2014.7.1 dask pin is removed, all
dask_cudf
tests usingread_parquet
andread_csv
will fail without this change...Checklist