Use make_host_vector instead of make_std_vector to facilitate pinned memory optimizations
#16386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libcudf
vuule
added
Performance
github-actions
bot
added
libcudf
github-actions
bot
removed
Python
vuule
commented
Jul 26, 2024
| @@ -1991,14 +1991,14 @@ encoder_decimal_info decimal_chunk_sizes(orc_table_view& orc_table, | |||
| return src[rg_bounds[idx][col_idx].end - 1]; | |||
| }); | |||
|
|
|||
| rg_sizes[col_idx] = cudf::detail::make_std_vector_async(d_tmp_rowgroup_sizes, stream); | |||
| rg_sizes.emplace(col_idx, cudf::detail::make_host_vector_async(d_tmp_rowgroup_sizes, stream)); | |||
There was a problem hiding this comment.
this is the only way to add elements to a map when the value type is not default-constructible.
ttnghia
reviewed
Aug 8, 2024
ttnghia
reviewed
Aug 8, 2024
ttnghia
approved these changes
Aug 27, 2024
|
/ok to test |
shrshi
reviewed
Aug 27, 2024
| is_str_column_all_nulls = cudf::detail::make_std_vector_sync( | ||
| is_all_nulls_each_column(input, d_column_tree, tree, col_ids, options, stream), stream); | ||
| } | ||
| auto const is_str_column_all_nulls = [&, &column_tree = d_column_tree]() { |
shrshi
approved these changes
Aug 27, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced most of
make_std_vectorcalls withmake_host_vectorto allow pinned memory and kernel copies, when enabled.Skipped places where the change would impact the public API.
Checklist