Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-24.08 into branch-24.10 #16364

Merged
merged 1 commit into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/cudf_polars/cudf_polars/dsl/expr.py
Original file line number Diff line number Diff line change
Expand Up @@ -1188,6 +1188,10 @@ class Cast(Expr):
def __init__(self, dtype: plc.DataType, value: Expr) -> None:
super().__init__(dtype)
self.children = (value,)
if not plc.unary.is_supported_cast(self.dtype, value.dtype):
raise NotImplementedError(
f"Can't cast {self.dtype.id().name} to {value.dtype.id().name}"
)

def do_evaluate(
self,
Expand Down
52 changes: 52 additions & 0 deletions python/cudf_polars/tests/expressions/test_casting.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES.
# SPDX-License-Identifier: Apache-2.0
from __future__ import annotations

import pytest

import polars as pl

from cudf_polars.testing.asserts import (
assert_gpu_result_equal,
assert_ir_translation_raises,
)

_supported_dtypes = [(pl.Int8(), pl.Int64())]

_unsupported_dtypes = [
(pl.String(), pl.Int64()),
]


@pytest.fixture
def dtypes(request):
return request.param


@pytest.fixture
def tests(dtypes):
fromtype, totype = dtypes
if fromtype == pl.String():
data = ["a", "b", "c"]
else:
data = [1, 2, 3]
return pl.DataFrame(
{
"a": pl.Series(data, dtype=fromtype),
}
).lazy(), totype


@pytest.mark.parametrize("dtypes", _supported_dtypes, indirect=True)
def test_cast_supported(tests):
df, totype = tests
q = df.select(pl.col("a").cast(totype))
assert_gpu_result_equal(q)


@pytest.mark.parametrize("dtypes", _unsupported_dtypes, indirect=True)
def test_cast_unsupported(tests):
df, totype = tests
assert_ir_translation_raises(
df.select(pl.col("a").cast(totype)), NotImplementedError
)
Loading